-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics interfaces #127
Merged
SergeyKanzhelev
merged 8 commits into
open-telemetry:master
from
SergeyKanzhelev:metrics
Jun 30, 2019
Merged
Metrics interfaces #127
SergeyKanzhelev
merged 8 commits into
open-telemetry:master
from
SergeyKanzhelev:metrics
Jun 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKanzhelev
requested review from
austinlparker,
discostu105 and
lmolkova
as code owners
June 28, 2019 06:57
z1c0
reviewed
Jun 28, 2019
src/OpenTelemetry.Abstractions/Metrics/Implementation/IMetricBuilder{T}.cs
Outdated
Show resolved
Hide resolved
z1c0
reviewed
Jun 28, 2019
src/OpenTelemetry.Abstractions/Metrics/Implementation/IMetricBuilder{T}.cs
Outdated
Show resolved
Hide resolved
z1c0
reviewed
Jun 28, 2019
lmolkova
reviewed
Jun 29, 2019
lmolkova
reviewed
Jun 29, 2019
src/OpenTelemetry.Abstractions/Metrics/Implementation/MeasureType.cs
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24
Interfaces only for metrics reporting. There is no way to instantiate it yet to start reporting those metrics.